Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(superchain): add github cli #2803

Merged
merged 2 commits into from
Apr 21, 2021
Merged

feat(superchain): add github cli #2803

merged 2 commits into from
Apr 21, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Apr 21, 2021

Adds GitHub CLI to superchain.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds GitHub CLI to superchain.
@eladb eladb requested a review from RomainMuller April 21, 2021 12:08
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add it to the README.md of superchain, too?

@RomainMuller RomainMuller added the pr/do-not-merge This PR should not be merged at this time. label Apr 21, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 21, 2021
@eladb eladb removed the pr/do-not-merge This PR should not be merged at this time. label Apr 21, 2021
@eladb
Copy link
Contributor Author

eladb commented Apr 21, 2021

Can you add it to the README.md of superchain, too?

Added

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Apr 21, 2021
@mergify mergify bot merged commit 23f3582 into main Apr 21, 2021
@mergify mergify bot deleted the benisrae/superchain/gh branch April 21, 2021 13:31
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Merging (with squash)...

@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants