feat(rosetta): make assembly validation opt-in #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assembly validation (i.e: checking that the content of the `.jsii` file correctly implements the `@jsii/spec` schema) can be slow and memory intensive. It is however typically not of great use, since we should normally be able to assume assemblies are valid. Added a `--validate-assemblies` option (default `false`) to control whether the JSON Schema validation is done or not.
RomainMuller
added
effort/small
RomainMuller
commented
Nov 16, 2020
Comment on lines
+22
to
37
| export async function loadAssemblies( | ||
| assemblyLocations: readonly string[], | ||
| validateAssemblies: boolean, | ||
| ): Promise<readonly LoadedAssembly[]> { | ||
| return Promise.all(assemblyLocations.map(loadAssembly)); | ||
|
|
||
| async function loadAssembly(location: string): Promise<LoadedAssembly> { | ||
| const stat = await fs.stat(location); | ||
| if (stat.isDirectory()) { | ||
| ret.push({ | ||
| assembly: await loadAssemblyFromFile(path.join(loc, '.jsii')), // eslint-disable-line no-await-in-loop | ||
| directory: loc, | ||
| }); | ||
| } else { | ||
| ret.push({ | ||
| assembly: await loadAssemblyFromFile(loc), // eslint-disable-line no-await-in-loop | ||
| directory: path.dirname(loc), | ||
| }); | ||
| return loadAssembly(path.join(location, '.jsii')); | ||
| } | ||
| return { | ||
| assembly: await loadAssemblyFromFile(location, validateAssemblies), | ||
| directory: path.dirname(location), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Re-worked this code largely to remove the linter exclusions... It does the same work, except in parallel instead of serially, which could be a little faster, since this involves I/O wait.
MrArnoldPalmer
approved these changes
Nov 16, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assembly validation (i.e: checking that the content of the
.jsiifilecorrectly implements the
@jsii/specschema) can be slow and memoryintensive. It is however typically not of great use, since we should
normally be able to assume assemblies are valid.
Added a
--validate-assembliesoption (defaultfalse) to controlwhether the JSON Schema validation is done or not.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.