feat: CDK Build Integration Test #1219

MrArnoldPalmer · 2020-01-27T03:37:10Z

Adds @jsii/integ-test private module for defining new integration tests.
Adds a new integration test that downloads the latest CDK release source
code and builds it with the local version of jsii and jsii-pacmak.

This unit test requires a github access token defined in the environment
to get the latest release version and download the asset.

Fixes: #1209

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

MrArnoldPalmer · 2020-01-27T03:41:35Z

@RomainMuller

Where is the best place to actually add yarn test:integ in our CD pipeline. I would think in the deploy pipeline but adding it to buildspec.yml means it will run on all PRs and other events? Do we need to specify some conditional logic in buildspec to decide?
Specified a 60min timeout which on my machine it finishes comfortably. That feel right to you?
Process management stuff is interesting, potentially we could do other integration testing in a similar way. I would like to build integration tests for the jsii-config tool with similar interactions via child_process.

aws-cdk-automation · 2020-01-27T03:47:35Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-27T03:47:36Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

packages/@jsii/integ-test/README.md

packages/@jsii/integ-test/package.json

packages/@jsii/integ-test/utils/index.ts

aws-cdk-automation · 2020-01-27T15:33:10Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-27T15:33:51Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-27T15:33:56Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-27T15:34:04Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-28T01:53:36Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-28T01:53:41Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller

Noice! Looking solid at this point... some super minor comments, but nothing blocking.

Waiting for you to figure out why the PR build does not pass & fix that :)

packages/@jsii/integ-test/test/build-cdk.test.ts

packages/@jsii/integ-test/utils/index.ts

aws-cdk-automation · 2020-01-29T01:45:18Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-29T01:49:47Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-29T18:48:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-29T18:48:53Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-30T00:03:22Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-01-30T00:04:45Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-10T02:16:15Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation · 2020-02-10T02:16:18Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

RomainMuller

Minor comments only!

packages/@jsii/integ-test/package.json

packages/@jsii/integ-test/test/build-cdk.test.ts

RomainMuller · 2020-02-10T14:26:07Z

packages/@jsii/integ-test/test/build-cdk.test.ts

+    await processes.spawn('npx', [
+      'lerna',
+      'run',
+      '--stream',
+      '--scope',
+      '@aws-cdk/*',
+      '--scope',
+      'aws-cdk',
+      'build',
+      '--',
+      '--jsii',
+      path.join(JSII_DIR, 'bin', 'jsii'),
+    ], { cwd: srcDir });


Instead of using the --jsii path/to/jsii argument, why not use the CDK_BUILD_JSII environment variable? Is there a difference?

RomainMuller · 2020-02-10T14:26:35Z

packages/@jsii/integ-test/tsconfig.json

@@ -0,0 +1,8 @@
+{
+  "compilerOptions": {
+    "composite": false,


Why? I reckon this also disables incremental...

tsc throws tsconfig.json(3,5): error TS6304: Composite projects may not disable declaration emit. ?

Oh yeah, right. Composite requires declarations... but why bother?

yeah idk, I wasn't quite sure the ideal solve here. Outputting declarations is fine? Just doesn't feel like we should need to do.

packages/@jsii/integ-test/utils/index.ts

rix0rrr · 2020-02-12T18:32:51Z

This unit test requires a github access token defined in the environment

Wait, why not clone the release branch of the public repo, or download the latest release's source? Neither of those should need a GitHub token, rite?

Adds @jsii/integ-test private module for defining new integration tests. Adds a new integration test that downloads the latest CDK release source code and builds it with the local version of jsii and jsii-pacmak. This unit test requires a github access token defined in the environment to get the latest release version and download the asset. Fixes: aws#1209

Co-Authored-By: Romain Marcadier-Muller <[email protected]>

Use the tar node module instead of shelling out to tar. This allows us to stream the download contents directly to unpacking and removes the need to manually parse the beginning of the commit id hash to traverse into the build directory.

MrArnoldPalmer · 2020-02-14T00:09:43Z

Wait, why not clone the release branch of the public repo, or download the latest release's source? Neither of those should need a GitHub token, rite?

We use the token to hit the GH API and get the tag of the latest release. Then using that tag we download the source from the archive. Neither of these actually requires a token but it gets rate limited pretty quickly without one.

Doing a git clone and checkout of the release branch wouldn't require a token, but I'd rather us know the specific tag we are checking out and not check out the latest release branch. In my mind its more robust? 🧐 Asking for "latest published release" vs git checkout release feels more decoupled.

Pull request has been modified.

aws-cdk-automation · 2020-02-14T01:20:24Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject6AEA49D1-Blkkw9bQFn8A
Commit ID: e90246f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

MrArnoldPalmer added the pr/do-not-merge This PR should not be merged at this time. label Jan 27, 2020

MrArnoldPalmer requested a review from a team as a code owner January 27, 2020 03:37

MrArnoldPalmer requested a review from RomainMuller January 27, 2020 03:41

RomainMuller suggested changes Jan 27, 2020

View reviewed changes

RomainMuller assigned MrArnoldPalmer Jan 27, 2020

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from a99ddf7 to ca6bf1b Compare January 28, 2020 01:48

MrArnoldPalmer requested a review from RomainMuller January 28, 2020 01:50

MrArnoldPalmer assigned RomainMuller Jan 28, 2020

RomainMuller reviewed Jan 28, 2020

View reviewed changes

packages/@jsii/integ-test/test/build-cdk.test.ts Outdated Show resolved Hide resolved

packages/@jsii/integ-test/utils/index.ts Show resolved Hide resolved

packages/@jsii/integ-test/utils/index.ts Outdated Show resolved Hide resolved

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from ca6bf1b to 342020b Compare January 29, 2020 01:36

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from 342020b to ae2cbb8 Compare January 29, 2020 18:38

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from ae2cbb8 to 1e76dd6 Compare January 29, 2020 23:51

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from 1e76dd6 to 6560d16 Compare February 10, 2020 02:05

RomainMuller reviewed Feb 10, 2020

View reviewed changes

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from 6560d16 to 241c5a7 Compare February 12, 2020 00:06

RomainMuller previously approved these changes Feb 12, 2020

View reviewed changes

MrArnoldPalmer requested a review from rix0rrr February 12, 2020 18:31

MrArnoldPalmer and others added 3 commits February 13, 2020 15:33

Apply suggestions from code review

83bc944

Co-Authored-By: Romain Marcadier-Muller <[email protected]>

Use tar Module and Cleanup

e90246f

Use the tar node module instead of shelling out to tar. This allows us to stream the download contents directly to unpacking and removes the need to manually parse the beginning of the commit id hash to traverse into the build directory.

MrArnoldPalmer removed the pr/do-not-merge This PR should not be merged at this time. label Feb 14, 2020

MrArnoldPalmer force-pushed the feature/cdk-build-integ-test branch from 241c5a7 to e90246f Compare February 14, 2020 01:07

MrArnoldPalmer merged commit e99d722 into aws:master Feb 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CDK Build Integration Test #1219

feat: CDK Build Integration Test #1219

MrArnoldPalmer commented Jan 27, 2020

MrArnoldPalmer commented Jan 27, 2020 •

edited

Loading

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 27, 2020

aws-cdk-automation commented Jan 28, 2020

aws-cdk-automation commented Jan 28, 2020

RomainMuller left a comment

aws-cdk-automation commented Jan 29, 2020

aws-cdk-automation commented Jan 29, 2020

aws-cdk-automation commented Jan 29, 2020

aws-cdk-automation commented Jan 29, 2020

aws-cdk-automation commented Jan 30, 2020

aws-cdk-automation commented Jan 30, 2020

aws-cdk-automation commented Feb 10, 2020

aws-cdk-automation commented Feb 10, 2020

RomainMuller left a comment

RomainMuller Feb 10, 2020

RomainMuller Feb 10, 2020

MrArnoldPalmer Feb 10, 2020

RomainMuller Feb 12, 2020

MrArnoldPalmer Feb 12, 2020

rix0rrr commented Feb 12, 2020

MrArnoldPalmer commented Feb 14, 2020

aws-cdk-automation commented Feb 14, 2020

feat: CDK Build Integration Test #1219

feat: CDK Build Integration Test #1219

Conversation

MrArnoldPalmer commented Jan 27, 2020

MrArnoldPalmer commented Jan 27, 2020 • edited Loading

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 27, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 28, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 28, 2020

AWS CodeBuild CI Report

RomainMuller left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Jan 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 29, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 30, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Jan 30, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 10, 2020

AWS CodeBuild CI Report

aws-cdk-automation commented Feb 10, 2020

AWS CodeBuild CI Report

RomainMuller left a comment

Choose a reason for hiding this comment

RomainMuller Feb 10, 2020

Choose a reason for hiding this comment

RomainMuller Feb 10, 2020

Choose a reason for hiding this comment

MrArnoldPalmer Feb 10, 2020

Choose a reason for hiding this comment

RomainMuller Feb 12, 2020

Choose a reason for hiding this comment

MrArnoldPalmer Feb 12, 2020

Choose a reason for hiding this comment

rix0rrr commented Feb 12, 2020

MrArnoldPalmer commented Feb 14, 2020

aws-cdk-automation commented Feb 14, 2020

AWS CodeBuild CI Report

MrArnoldPalmer commented Jan 27, 2020 •

edited

Loading