feat: golang release #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliapolo
commented
Jan 26, 2021
eladb
reviewed
Jan 26, 2021
eladb
reviewed
Jan 26, 2021
eladb
reviewed
Jan 31, 2021
| target_repo_dir=$(mktemp -d)/repo | ||
|
|
||
| echo "Cloning target repository ${GITHUB_REPO}" | ||
| git clone https://${GITHUB_TOKEN}@github.com/${GITHUB_REPO}.git ${target_repo_dir} |
There was a problem hiding this comment.
If we push to a branch other than main, and that branch is more than 1 commits behind main, the branch won't be fetched, which will cause the script to incorrectly create it.
| git checkout -B ${GIT_BRANCH} | ||
|
|
||
| echo "Copying go module to repository root" | ||
| cp -r ${dir}/* . |
There was a problem hiding this comment.
How does this handle deleted files?
There was a problem hiding this comment.
Good point. It doesn't. I'll fix.
iliapolo
commented
Jan 31, 2021
bin/jsii-release-golang
Outdated
| @@ -122,10 +122,19 @@ pushd ${target_repo_dir} | |||
| git config user.name ${GIT_USER_NAME} | |||
| git config user.email ${GIT_USER_EMAIL} | |||
|
|
|||
| # -B to create if it doesn't exist, reset otherwise | |||
| git checkout -B ${GIT_BRANCH} | |||
There was a problem hiding this comment.
This didn't do what I thought it did, and always created a new branch even if git checkout would work.
eladb
reviewed
Jan 31, 2021
| if $dry_run; then | ||
| echo "Will create a tag: ${tag_name}" | ||
| else | ||
| git push origin ${tag_name} |
There was a problem hiding this comment.
Do we also need to push to the branch?
There was a problem hiding this comment.
You mean should we skip pushing to the branch?
eladb
approved these changes
Jan 31, 2021
mergify bot
pushed a commit
to aws/jsii
that referenced
this pull request
Feb 2, 2021
Since golang version isn't available anywhere inside the module, we embed a version file so that consumers can access the version. This is needed for publishing [go modules](cdklabs/publib#23) using `jsii-release` without the user having to supply the version externally. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
This was referenced Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishes a directory that is expected to be the output of
jsii-pacmak(i.edist/go) to the appropriate GitHub repo.