Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Gremlin protocol and serializer based on database type #697

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Sep 19, 2024

Issue #, if available: N/A

Description of changes:

  • Reworked Gremlin config generation to set allowed inputs and defaults for connection_protocol and message_serializer based on service type
  • Fixed message_serializer not enforcing serializer input compatible with the GremlinPython driver when connecting to non-Neptune endpoints
  • Temporarily restricted message_serializer to GraphSON-untyped serializers on HTTP connections

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin force-pushed the gremlin-expanded-serializers-neptune-adjustments branch from 5f19ed4 to 339be6c Compare September 20, 2024 02:06
@michaelnchin michaelnchin marked this pull request as ready for review September 20, 2024 04:12
@michaelnchin michaelnchin merged commit 9997b1c into main Sep 20, 2024
4 checks passed
@michaelnchin michaelnchin deleted the gremlin-expanded-serializers-neptune-adjustments branch September 20, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant