Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Prometheus metrics without ServiceMonitor #959

Closed
prashcr opened this issue Jun 14, 2023 · 1 comment · Fixed by #1155
Closed

Enable Prometheus metrics without ServiceMonitor #959

prashcr opened this issue Jun 14, 2023 · 1 comment · Fixed by #1155
Labels
enhancement New feature or request

Comments

@prashcr
Copy link

prashcr commented Jun 14, 2023

Is your feature request related to a problem?
I want to enable Prometheus metrics from aws-load-balancer-controller without creating a ServiceMonitor and having Prometheus Operator on my EKS cluster. This is because I'm using an alternative Prometheus collector: Grafana Agent.

Currently the Helm chart defines a single serviceMonitor.enabled variable to enable both the Prometheus metrics service and the ServiceMonitor.

Is your feature request related to a specific Helm chart, if yes mention name of the chart?
My primary concern is aws-load-balancer-controller though this applies to all charts that expose a Prometheus metrics endpoint (e.g. aws-node-termination-handler, aws-for-fluent-bit)

Describe the solution you'd like
The Helm charts defines a new metrics.enabled variable. The metrics Service is created if metrics.enabled OR serviceMonitor.enabled

Describe alternatives you've considered
None.

@prashcr
Copy link
Author

prashcr commented Jun 14, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant