[aws-for-fluent-bit] Upgrading to 0.1.14

[mickeypash]

Describe the bug

We had an unpinned version of AWS for FluentBit running.
Yesterday when the update was released
It caused the issue seen below:

Error: UPGRADE FAILED: cannot patch "aws-for-fluent-bit" with kind DaemonSet: DaemonSet.apps "aws-for-fluent-bit" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{"app.kubernetes.io/instance":"aws-for-fluent-bit", "app.kubernetes.io/name":"aws-for-fluent-bit"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable

I believe this the diff that caused the issue:

- app.kubernetes.io/instance: {{ include "aws-for-fluent-bit.namespace" . }}
+ app.kubernetes.io/instance: {{ include "aws-for-fluent-bit.fullname" . }}

• selector label diff in latest update

Workarounds:

• delete the release - this is not an option I think as we might lose logs?
• pin the version to 0.1.13 - this is what we did because it was blocking our CI/CD pipeline. But we need some way of upgrading to the latest version.

Read K8s discussion: kubernetes/kubernetes#50808

Steps to reproduce

Run the following while having 0.1.13 running before

helm upgrade --install aws-for-fluent-bit eks/aws-for-fluent-bit  --version 0.1.14 -n kube-system -f helm/fluent-bit.yml \
  --set 'cloudWatch.region'=us-east-1 \
  --set 'cloudWatch.logGroupName'=/test_flb \
  --set 'cloudWatch.logRetentionDays'=30 

Expected outcome
A concise description of what you expected to happen.

Environment

• Chart name: aws-for-fluent-bit
• Chart version: 0.1.14
• Kubernetes version: 1.21
• Using EKS (yes/no), if so version? yes

Additional Context:

[jtackaberry]

Ran into this, and also pinned to 0.1.13. If this is intended behavior, the chart's major version should be bumped.

[mickeypash]

I was wondering whether it's better to move to the FLB helm charts instead https://github.com/fluent/helm-charts/tree/main/charts/fluent-bit