Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear status for a successful reconciliation in processInstalled function #964

Open
vincentni opened this issue Jul 21, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@vincentni
Copy link
Member

What happened:
For an installed package, if the previous run of reconciliation ran into an error, such error message won't get cleared in subsequent successful runs of reconciliation if no config changes are made to that installed package.

What you expected to happen:
The status detail of a package resource should be cleared if the current reconciliation succeeds. The relevant code is https://github.com/aws/eks-anywhere-packages/blob/main/pkg/packages/manager.go#L177-L219.

@vincentni vincentni added the bug Something isn't working label Jul 21, 2023
@TerryHowe
Copy link
Contributor

I recall there was a bug regarding clearing Detail early on and I think this issue represents that problem. The customer was running a very old version of the controller, it did not clear status. They installed a new controller and it would not have the same issue, but until they upgrade, it will not update Detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants