Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.1 ActiveRecord support #57

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Conversation

johan-smits
Copy link
Contributor

Issue #, if available: #56

Description of changes: Support ActiveRecord 6.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @johan-smits! This change looks fine to me - I noticed we don't seem to have any tests for rails :( Would adding a test that uses rails 6.1 be something you can help us with? If not no worries and we'll merge this

@johan-smits
Copy link
Contributor Author

@anuraaga I did not find any tests for ActiveRecord thats why I did not add one. If you can point me out where they are I'm happy to add a new one.

@anuraaga
Copy link
Contributor

Right :) That's the same conclusion I came to when looking through this repo for the first time. So it would start from adding rails as a dev dependency in the gemspec.

You don't have to do it of course :) Our team unfortunately doesn't have anyone super familiar with rails right now so we really appreciate the help from the community here - if you could add the dependency and a test using it similar to what we have in test, it would be really awesome. If not, it's also still awesome to have this PR so no worries.

@johan-smits
Copy link
Contributor Author

@anuraaga not sure on how to make a test for this, I'm familiar with ActiveRecord but not so much on the testing area. Since it this code

DB_TYPE_MAPPING = {
mysql2: 'MySQL',
postgresql: 'PostgreSQL'
}.freeze
also only works with MySQL and PG, so this should also be setup to test this change.

@anuraaga
Copy link
Contributor

@johan-smits No worries let's merge this in :) Thanks!

@anuraaga anuraaga merged commit e6bbe20 into aws:master Dec 25, 2020
@johan-smits
Copy link
Contributor Author

@anuraaga thanks, when would this get released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants