Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing rds data service sdk #42

Merged
merged 1 commit into from
Jan 20, 2020
Merged

add missing rds data service sdk #42

merged 1 commit into from
Jan 20, 2020

Conversation

lloydpick
Copy link
Contributor

Description of changes:

When I was trying to use the RDS Data API client it threw errors because it wasn't patching it as it's missing from the services list.

For anyone that needs a workaround in the meantime it's...

require "aws-xray-sdk/facets/resources/aws_services_whitelist"
XRay::AwsServices.whitelist << :RDSDataService

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@metaskills
Copy link

Thanks for making this PR @lloydpick, came here today for other reasons and found this happy little gem. Trying it out now and mixing the Lambda context for Rails and Lambda using RDS. https://technology.customink.com/blog/2020/01/03/migrate-your-rails-app-from-heroku-to-aws-lambda/

Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the issue and submitting a fix!

@srprash srprash merged commit af95014 into aws:master Jan 20, 2020
@lloydpick lloydpick deleted the add-rds-data-api branch January 20, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants