From 7e935116ad45b109831d4dba6f178f4d9c22ce8b Mon Sep 17 00:00:00 2001 From: William Armiros <54150514+willarmiros@users.noreply.github.com> Date: Fri, 12 Nov 2021 09:47:36 -0800 Subject: [PATCH] Reduce log level of sampling error logging (#309) * Reduce log level of target poller throwables * Update RulePoller.java * Update RulePoller.java * Update TargetPoller.java --- .../amazonaws/xray/strategy/sampling/pollers/RulePoller.java | 2 +- .../amazonaws/xray/strategy/sampling/pollers/TargetPoller.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java index 98842a8b..bb2ee9e2 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/RulePoller.java @@ -71,7 +71,7 @@ public void start() { try { pollRule(); } catch (Throwable t) { - logger.error("Encountered error polling GetSamplingRules: ", t); + logger.info("Encountered error polling GetSamplingRules: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java diff --git a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java index 223167ce..50991548 100644 --- a/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java +++ b/aws-xray-recorder-sdk-core/src/main/java/com/amazonaws/xray/strategy/sampling/pollers/TargetPoller.java @@ -66,7 +66,7 @@ public void start() { try { pollManifest(); } catch (Throwable t) { - logger.error("Encountered error polling GetSamplingTargets: ", t); + logger.info("Encountered error polling GetSamplingTargets: ", t); // Propagate if Error so executor stops executing. // TODO(anuraaga): Many Errors aren't fatal, this should probably be more restricted, e.g. // https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/internal/Throwables.java