Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazon q): add pl/1 and bms extensions as a recognized code file type #6067

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

scottwritescode
Copy link

@scottwritescode scottwritescode commented Nov 20, 2024

Problem

The codefileExtensions does not contain an extension type for .pli which is the common extension for PL/1, or for .bms which is Basic Mapping Support and common for screen definition files in IBM mainframe. Because of this, the files and code in them are not accessible in the workspace context for Amazon Q using the /dev quick action.

When using the Q quick action '\dev' for .pli or .bms files, Q responds with the following message

This appears to be an empty program or workspace with no source files present. There is nothing to explain at this time since no code or files are available for analysis.

Solution

  • Add the PL/1 language extension .pli as a known code file extension type
  • Add the Basic Mapping Support extension .bms as a known code file extension type

No tests were updated as there are none exclusively for filetype extensions


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@scottwritescode scottwritescode changed the title fix(filetypes): add pl1 extension as a recognized code file type fix(filetypes): add pl1 and bms extension as a recognized code file type Nov 20, 2024
@scottwritescode scottwritescode changed the title fix(filetypes): add pl1 and bms extension as a recognized code file type fix(filetypes): add pl1 and bms extensions as a recognized code file type Nov 20, 2024
@scottwritescode scottwritescode changed the title fix(filetypes): add pl1 and bms extensions as a recognized code file type fix(filetypes): add pl/1 and bms extensions as a recognized code file type Nov 20, 2024
@scottwritescode scottwritescode marked this pull request as ready for review November 20, 2024 22:21
@scottwritescode scottwritescode requested a review from a team as a code owner November 20, 2024 22:21
@scottwritescode scottwritescode changed the title fix(filetypes): add pl/1 and bms extensions as a recognized code file type fix(amazon q): add pl/1 and bms extensions as a recognized code file type Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant