Fix Rust installation, as it's expecting confirmation (typing 'y') to…

[patrocinio]

… proceed

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[simonmarty]

Thanks for fixing that, LGTM

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (11c92f2) to head (beb3205).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   68.89%   68.89%           
=======================================
  Files          14       14           
  Lines        2887     2887           
  Branches       11       11           
=======================================
  Hits         1989     1989           
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joebaro]

We should not deviate from the official rust installation instructions. Skipping the installation prompts risks the user being unaware of what is being installed and if the rust installation script detects problems and presents warnings these might be ignored. This might also ignore important prompts added in the future as well.

That said, it is perfectly fine to adjust the explanatory text to mention that the user should follow the prompts and/or to add a hint (in text) that installation can be automated using sh -s -- -y, but we should not present that as the default.

[simonmarty]

We already provide a link to the Rust installation instructions right above these code lines. Based on Joe's comment, I'm going to go ahead and close this pull request.

[patrocinio]

@simonmarty and @joebaro I understand your point.
But the installation fails as it's documented.
If the user copies the two commands:

curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
. "$HOME/.cargo/env"

as indicated in the instructions, the ". "HOME..." will be pasted instead of the 'y'.
So the instruction needs to decouple these two lines.

[simonmarty]

Clarified it in #27. Maybe we should just delete that code block entirely and just point users to the Rust installation documentation to reduce confusion if these instructions change in the future.

[joebaro]

Adding a ; to the end of the sh line should also fix it.