Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Support of http_proxy and https_proxy in config file #538

Closed
2 tasks done
AlexVulaj opened this issue May 16, 2023 · 4 comments
Closed
2 tasks done

Support of http_proxy and https_proxy in config file #538

AlexVulaj opened this issue May 16, 2023 · 4 comments
Assignees
Labels
cross-sdk feature-request New feature or request

Comments

@AlexVulaj
Copy link

AlexVulaj commented May 16, 2023

Describe the feature

Currently, using an http/https proxy for commands requires exporting HTTP_PROXY or HTTPS_PROXY as an environment variable as per the existing docs. It would be convenient if these proxies could instead be declared in configuration specific to the AWS CLI to encapsulate the change.

Use Case

As a user, I would like to set an https_proxy that my aws-cli always uses so that I am always accessing our customers' resources through a published, company owned IP. Setting this in a configuration file one time would allow this change to survive terminal restarts, as well as prevent the environment variable from needlessly impacting other terminal commands.

Proposed Solution

When running commands, the AWS CLI should check for the existence of a proxy variable in ~/.aws/config (or %UserProfile%\.aws\config on Windows) and use that when making calls.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CLI version used

aws-cli/2.11.12

Environment details (OS name and version, etc.)

Darwin/22.4.0 source/arm64

@AlexVulaj AlexVulaj added feature-request New feature or request needs-triage labels May 16, 2023
@tim-finnigan
Copy link
Contributor

Thanks @AlexVulaj for the feature request. I'm going to transfer this to our cross-SDK repository for further review. Requests involving configurations should be considered across SDKs to maintain consistency. It looks like some SDKs don't even support the environment variables (Rust, .NET, Java...) so I think this is worth looking into further.

@Mythra
Copy link

Mythra commented Jul 12, 2023

Hey I just got pointed to this from our PR adding support for the environment variables for proxies to .NET! Let me know if we can be of any help discussing what to do with overarching decisions (whether it be adding use cases about why it's useful, or something else)! We'd be happy to do whatever we could.

For the three clients that don't support this proxying today (via environment variables -- Rust, Java-v2, and .NET) we had planned on opening PRs for each (though we only have PRs open for the two GA clients right now -- Java-v2 & .NET). We'll hold off on that third PR for now to not cause any extra work, but are very interested in getting this supported on every single SDK. Having it configuration too would be really nice!

@tim-finnigan tim-finnigan removed their assignment Sep 28, 2023
@RanVaknin RanVaknin assigned jmklix and unassigned khushail Mar 1, 2024
@kellertk
Copy link
Contributor

kellertk commented May 9, 2024

This is a duplicate of #127 . Closing here to track there.

@kellertk kellertk closed this as completed May 9, 2024
Copy link

github-actions bot commented May 9, 2024

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cross-sdk feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants