-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2 Client does not honor parameters #39
Comments
The value you should pass is actually |
Good catch! It changed the results, but it wasn't why I expected. I changed it to handle a very simple case first:
And didn't get any results..., where without the Filter I get 197 results (mixed with running and stopped states). |
See the API docs for DescribeInstances.
There is also an example in the EC2 integration tests. |
Awesome! Thanks for pointing that out. |
I Briefly ran through the code, but it looks like params are not being passed on the ec2 client (the only PostField for curl on the stack was the 'describeInstances' method name). For example:
$response = $ec2->describeInstances(array(
'Filter' => array(
// So AWS isn't exactly honoring this filter, will need to double check below
array(
'Name' => 'instance-state-name',
'Value' => $filterStopped ? 'running' : '*'
),
array(
'Name' => 'tag-key',
'Value' => $tag
)
)
));
Returns the entire corpus of our ec2 account and does not do any filtering.
The text was updated successfully, but these errors were encountered: