-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retries option ignored for async requests #1214
Comments
@NinoSkopac Could you explain a bit how you find this doesn't work? I tried to reproduce this with a You could try to verify by turning on |
@NinoSkopac I noticed that you have mentioned 'async' behavior, different people might do this quite differently, so it would be great if you could provide some code snippets that might help us reproduce the issue : ) |
@cjyclaire Did you find out anything? |
@NinoSkopac Sorry for the delay. Have you tried to contact the Polly team to increase your rate limit? |
Yeah, and they declined. |
@NinoSkopac Sorry for the late reply. The PHP SDK use Guzzle library to make any requests. All async requests if failed are automatically retried. Here is some documentation on the concept of Promise: https://docs.aws.amazon.com/aws-sdk-php/v3/guide/guide/promises.html It will be a lot more helpful if you can share us what errors you are getting so that we can reproduce it. |
Hey @imshashank. I am familiar with Guzzle and Promises.
Question: is their order preserved in case of a failed request?
Sure. Keep in mind that these errors are from 23 days ago, when I wasn't capping the concurrent request count to 80 with
|
@NinoSkopac PHP SDK will use multi_curl for sending async requests. A new request is retried when a previous once fails and hence the order is preserved until it's scheduled using multi_curl. Are you still facing this issue? |
I'm not facing the issue since I've migrated to |
I am using AWS Polly with AWS SDK for PHP in async mode.
Polly has a rate limit of 80 per second, whereas I want to be able to burst and do more than that, and in case Polly API returns 503 Rate Limiting, I want to retry the request (my script works fine if under rate limit).
The docs state there's a retries option, but it does nothing: it doesn't matter if i set it to 0 or 1000, it doesn't seem to retry and I get rejected promises from the SDK.
The text was updated successfully, but these errors were encountered: