Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize building repository #326

Merged
merged 10 commits into from
Aug 21, 2019
Merged

Conversation

AllanZhengYP
Copy link
Contributor

  • Switching over to yarn workspace to optimize the repo's bootstrap performance. The full repo bootstrap time is reduced to ~70 seconds.
  • The test scripts now only compile and test the packages that:
    • changed from the last tag
    • have direct or indirect dependency over changed packages
    • have direct or inderect dependents that are changed packages
  • Add a 'test-all' script to compile/test all the packages

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP
Copy link
Contributor Author

This is ready to be reviewed. I'm still using npm run script because yarn run script currently doesn't seem to conform pre and post script hook. I will look into this later. Now the scripts all work fine with npm command.

@trivikr
Copy link
Member

trivikr commented Aug 21, 2019

Let.s use yarn for everything as follows:

  • Replace npm run with yarn in all package.json files
  • Replace npm commands with yarn in CONTRIBUTING.md and .travis.yml:
    • replace npm install with yarn
    • remove npm run bootstrap (as yarn now does bootstrapping)
    • replace npm test with yarn test
  • Remove yarn.lock from .gitignore so that we commit lock files and lock our dependencies

@AllanZhengYP
Copy link
Contributor Author

AllanZhengYP commented Aug 21, 2019

@trivikr
Updated all the scripts to use yarn already #327
Some generated clients still have local npm scripts. Will update them in another PR.

@trivikr
Copy link
Member

trivikr commented Aug 21, 2019

I ran the following commands on 2473c5b in addition to removing yarn.lock from .gitignore on m4.2xlarge:

yarn --version: 1.17.3

.travis.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
buildspec.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@trivikr trivikr merged commit 00443da into aws:master Aug 21, 2019
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants