Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shared Glacier plugin with accountIdDefaultMiddleware #548

Merged
merged 4 commits into from
Dec 11, 2019
Merged

feat: shared Glacier plugin with accountIdDefaultMiddleware #548

merged 4 commits into from
Dec 11, 2019

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Dec 10, 2019 •
edited
Loading

  • Set accountId default value on Glacier requests
  • get apiVersion from config for addGlacierApiVersionMiddleware
  • use getGlacierPlugin to apply all Glacier middleware together
  • remove inputDefault middleware

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from AllanZhengYP December 10, 2019 23:46
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AllanZhengYP
AllanZhengYP approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on JS side

@srchase srchase requested a review from kstich December 10, 2019 23:54
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Dec 11, 2019
@srchase srchase requested a review from AllanZhengYP December 11, 2019 18:23
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase changed the title feat: add and apply accountIdDefaultMiddleware feat: shared Glacier plugin with accountIdDefaultMiddleware Dec 11, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@srchase srchase mentioned this pull request Dec 11, 2019
Closed
@srchase srchase merged commit 494c922 into aws:smithy-codegen Dec 11, 2019
@srchase srchase deleted the input-default branch December 11, 2019 22:37
@lock
Copy link

lock bot commented Dec 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

@kstich kstich Awaiting requested review from kstich

Assignees
No one assigned
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srchase @aws-sdk-js-automation @AllanZhengYP