Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove protocol rest json class #438

Merged

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Nov 8, 2019

  • Use string to model serializing protocol instead.
  • Remove deprecated type definitions for client and command

This pr contains #437

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Nov 8, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (smithy-codegen@6bd0469). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             smithy-codegen     #438   +/-   ##
=================================================
  Coverage                  ?   96.27%           
=================================================
  Files                     ?       72           
  Lines                     ?     1235           
  Branches                  ?      223           
=================================================
  Hits                      ?     1189           
  Misses                    ?       46           
  Partials                  ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bd0469...53f8bdb. Read the comment docs.

@AllanZhengYP AllanZhengYP requested a review from srchase November 8, 2019 20:03
@AllanZhengYP AllanZhengYP merged commit 851c122 into aws:smithy-codegen Nov 9, 2019
@AllanZhengYP
Copy link
Contributor Author

@mtdowling Note signature change to Client and Command class signature.

export class RdsDataService extends SmithyClient<
__HttpOptions,
ServiceInputTypes,
ServiceOutputTypes,
RdsDataServiceResolvedConfig
> {

export class ExecuteStatementCommand extends Command<
ServiceInputTypes,
ExecuteStatementRequest,
ServiceOutputTypes,
ExecuteStatementResponse,
RdsDataServiceResolvedConfig
> {

@lock
Copy link

lock bot commented Nov 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants