-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update runtime plugin interface #400
feat: update runtime plugin interface #400
Conversation
Now a plugin is a function that return a list of middlewares together with handler options. Update some client middleware with the new plugin interface: content length; retry; signing; user agent;
* support adding multiple middleware * support optionally remove existing middleware before inserting new middleware
Instead, use the runtime-specific utils specified in client config
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #400 +/- ##
==================================================
- Coverage 96.97% 96.72% -0.26%
==================================================
Files 69 69
Lines 1158 1161 +3
Branches 213 214 +1
==================================================
Hits 1123 1123
- Misses 35 38 +3
Continue to review full report at Codecov.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
3fd9762
to
045f83a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description of changes:
Update runtime plugin interface so it mutates the existing middleware stack from client or commands. Link
Merge serialize middleware and deserializer middleware into a single
serdePlugin
containing the 2 middlewareGenerated serializer & deserializer now doesn't import any runtime-specific dependencies. Instead, we are generating transfer-protocol-specific utils interface along with serializer & deserializer. The utils value should be set inside the client config
/cc @mtdowling @srchase
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.