Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages): end support for Node.js 10.x #3141

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 5, 2022

Issue

We announced the end of support for Node.js 10.x in the AWS SDK for JavaScript (v3) starting January 1, 2022 back in July.
The value for engines.node was bumped for clients in #3122, but was missed for non-clients.

Description

Bump engines to node >=12.0.0 in package.json for non-clients

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner January 5, 2022 17:59
@codecov-commenter
Copy link

Codecov Report

Merging #3141 (4917a4b) into main (7a207a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3141   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files         474      474           
  Lines       20724    20724           
  Branches     4756     4756           
=======================================
  Hits        15584    15584           
  Misses       5140     5140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a207a9...4917a4b. Read the comment docs.

@trivikr trivikr requested a review from AllanZhengYP January 6, 2022 00:11
@trivikr trivikr merged commit 1a62865 into aws:main Jan 6, 2022
@trivikr trivikr deleted the end-support-node-10 branch January 6, 2022 00:31
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants