Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump up tslib to 2.3.0 #2601

Merged
merged 6 commits into from
Jul 21, 2021
Merged

fix: bump up tslib to 2.3.0 #2601

merged 6 commits into from
Jul 21, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Resolves #2587
Resolves #2582

Description

  • Bump up tslib version from "^2.0.0" to ^2.3.0
  • Add a CI test that will fail everytime we upgrade TypeScript version. It will bring attentions and make sure tslib version is bumped up at the same time.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP
Copy link
Contributor Author

CI is broken for ts-node:

error [email protected]: The engine "node" is incompatible with this module. Expected version ">=12.0.0". Got "10.23.0"
error Found incompatible module.

@AllanZhengYP
Copy link
Contributor Author

Bumped the node.js in runtime from 10 to 12 to fix the issue

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

tests/versions/tslib.ts Outdated Show resolved Hide resolved
tests/versions/tslib.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved

console.log("Validating the tslib and tsc version is consistent within workspace.");
const expectedVersions: { [name: string]: string } = JSON.parse(readFileSync(join(__dirname, "versions.json"), "utf8"));
const packagesInfo: PackageInfo[] = JSON.parse(execSync("./node_modules/.bin/lerna list -l --json").toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling lerna with execSync, should we call subdirectories of workspaces listed in root package.json?

That way, we won't have a dependency on lerna from the test code.

@trivikr
Copy link
Member

trivikr commented Jul 20, 2021

The code change to upgrade tslib version looks good to me.
The test:versions be moved to a separate PR, as all my comments are related to it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@63198f5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5cbc92b differs from pull request most recent head 616bd3a. Consider uploading reports for the commit 616bd3a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2601   +/-   ##
=======================================
  Coverage        ?   60.33%           
=======================================
  Files           ?      516           
  Lines           ?    27450           
  Branches        ?     6595           
=======================================
  Hits            ?    16561           
  Misses          ?    10889           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63198f5...616bd3a. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 616bd3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 7040faa into aws:main Jul 21, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get configuration from AppConfig on browser TypeError when creating new CognitoIdentityClient
5 participants