Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run downlevel-dts in prepublishOnly #2218

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 7, 2021

Issue

Fixes: #2217

Description

Runs downlevel-dts in prepublishOnly, so that downlevelled types are emitted just before publish

Testing

Verified the ts3.4 folder is not created after yarn build:all
Verified that ts3.4 folder is created after ./node_modules/.bin/lerna run prepublishOnly


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: d23fb7a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 0745502 into aws:main Apr 8, 2021
@trivikr trivikr deleted the downlevel-dts-prepublishOnly branch April 8, 2021 13:22
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@aws-sdk/types 3.10.0 broke Typescript 3 compatibility
3 participants