Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apiVersion from configuration #1869

Closed
trivikr opened this issue Jan 5, 2021 · 3 comments · Fixed by #2019
Closed

Remove apiVersion from configuration #1869

trivikr opened this issue Jan 5, 2021 · 3 comments · Fixed by #2019
Assignees
Labels
bug This issue is a bug. documentation This is a problem with documentation. feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 5, 2021

Describe the bug
The AWS SDK for JavaScript v3 is codegen and doesn't support multiple API versions for a client.
However, it accepts apiVersion in the configuration which can be confusing as discussed in #1844

SDK version number
3.1.0

Is the issue in the browser/Node.js/ReactNative?
All

Details of the browser/Node.js/ReactNative version
N/A

To Reproduce (observed behavior)

const { Lambda } = require("@aws-sdk/client-lambda")

const lambda = new Lambda({
  region: "ap-south-1",
  apiVersion: "2015-03-31"
});

Expected behavior
Do not allow apiVersion in client configuration.

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2021
@AllanZhengYP
Copy link
Contributor

AllanZhengYP commented Feb 10, 2021

As removing this parameter will likely to break users, we will add a @internal to the doc instead.

@AllanZhengYP AllanZhengYP added documentation This is a problem with documentation. feature-request New feature or enhancement. May require GitHub community feedback. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2021
@AllanZhengYP AllanZhengYP added the bug This issue is a bug. label Feb 10, 2021
@trivikr
Copy link
Member Author

trivikr commented Feb 11, 2021

we will add a @internal to the doc instead.

Verified that @internal marks the code as internal:

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. documentation This is a problem with documentation. feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants