Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware-sdk-sqs): call next() exactly once in sendMessageMiddleware #1752

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 8, 2020

Issue #, if available:
Fixes: #1742

Description of changes:
call next() exactly once in sendMessageMiddleware

Verified that the issue is not reproducible with code from #1742 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from alexforsyth December 8, 2020 06:21
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢, We should've catch it before😔

@trivikr trivikr merged commit dc63e37 into aws:master Dec 9, 2020
@trivikr trivikr deleted the sqs-fix-send-message branch December 9, 2020 03:05
@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQS sendMessage sends messages twice
2 participants