fix: toposort and chunk shape models #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
==========================================
- Coverage 79.80% 79.67% -0.14%
==========================================
Files 298 300 +2
Lines 11502 11654 +152
Branches 2475 2486 +11
==========================================
+ Hits 9179 9285 +106
- Misses 2323 2369 +46
Continue to review full report at Codecov.
|
AllanZhengYP
force-pushed
the
fix-stack-overflow
branch
2 times, most recently
from
08852ca to
d8060f8
Compare
AllanZhengYP
force-pushed
the
fix-stack-overflow
branch
from
d8060f8 to
450b9f9
Compare
trivikr
changed the title
trivikr
approved these changes
Sep 14, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1460
Description of changes:
For some clients,
models/index.tsis so big that TSC gets stack overflow when walking the AST. This change chunks the big files into smaller chunks, so TSC doesn't need to load whole tree to resolve the nodes. This change also split the shapes that has recursive reference and doesn't have recursive reference.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.