Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add transformation for AWS Config endpoint #693

Closed
1 task
trivikr opened this issue Nov 6, 2023 · 5 comments · Fixed by #840
Closed
1 task

[Feature]: Add transformation for AWS Config endpoint #693

trivikr opened this issue Nov 6, 2023 · 5 comments · Fixed by #840
Labels
enhancement New feature or request p2 This is a standard priority issue

Comments

@trivikr
Copy link
Member

trivikr commented Nov 6, 2023

Self-service

  • I'd be willing to implement this feature

Problem

Transformer does not transform config endpoint from v2 to v3.

Input

import AWS from "aws-sdk";

const client = new AWS.DynamoDB({
  endpoint: "http://localhost",
});

Output

import { DynamoDB } from "@aws-sdk/client-dynamodb";

const client = new DynamoDB({
  // The transformation for endpoint is not implemented.
  // Refer to UPGRADING.md on aws-sdk-js-v3 for changes needed.
  // Please create/upvote feature request on aws-sdk-js-codemod for endpoint.
  endpoint: "http://localhost",
});

Solution

Add transformation for endpoint, where there are no changes in output code.

Alternatives

N/A

Additional context

https://github.com/CrowdDotDev/crowd.dev/blob/01dc55271f5f2572e16fd092c7f719f29fc2f2fb/backend/src/services/aws.ts#L22

@trivikr trivikr added the enhancement New feature or request label Nov 6, 2023
@naeemshaikhtw
Copy link

naeemshaikhtw commented Dec 27, 2023

+1
or add clear instruction about what needs(or not) to be done.

@trivikr trivikr added the p2 This is a standard priority issue label Apr 9, 2024
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants