Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CRT version to 0.29.25 and pass operation name to CRT in CRT bas… #5325

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jun 24, 2024

…ed S3 client as it will be changed to required soon

Motivation and Context

Modifications

Testing

Added unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

…ed S3 client as it will be changed to required soon
@zoewangg zoewangg requested a review from a team as a code owner June 24, 2024 20:51
@@ -121,7 +121,7 @@
<rxjava.version>2.2.21</rxjava.version>
<commons-codec.verion>1.15</commons-codec.verion>
<jmh.version>1.37</jmh.version>
<awscrt.version>0.29.23</awscrt.version>
<awscrt.version>0.29.25</awscrt.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any runtime checks we need to update, to ensure the user has installed>= 0.29.25?

@zoewangg zoewangg enabled auto-merge (squash) June 28, 2024 16:03
Copy link

sonarcloud bot commented Jun 28, 2024

@zoewangg zoewangg merged commit c59a075 into master Jun 28, 2024
17 checks passed
@zoewangg zoewangg deleted the zoewang/crt0.29.25 branch June 28, 2024 17:00
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
…ed S3 client as it will be changed to required soon (aws#5325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants