Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should support https.proxyHost and https.proxyPort system properties #1334

Closed
stamhankar999 opened this issue Jul 9, 2019 · 2 comments · Fixed by #3398
Closed

SDK should support https.proxyHost and https.proxyPort system properties #1334

stamhankar999 opened this issue Jul 9, 2019 · 2 comments · Fixed by #3398
Labels
feature-request A feature should be added or improved.

Comments

@stamhankar999
Copy link

Expected Behavior

http.proxyHost and http.proxyPort system properties are supported for hitting an http proxy, but https.proxyHost and https.proxyPort are not supported.

Current Behavior

https.proxyHost and https.proxyPort are not supported.

Possible Solution

  • Update ProxySystemSetting to have new enum values for https.proxyHost, https.proxyPort, and https.nonProxyHosts. Not sure if it makes sense to duplicate proxyUser and proxyPassword enums.

  • Update ProxyConfiguration to resolve host/port by checking for https proxy properties first, and if not set then check for http proxy properties, else no proxy. Update resolveScheme to set the scheme to 'http' or 'https' depending on which system properties are set (if any).

Context

I have an https proxy in one deployment environment, and no proxy in another environment.

Your Environment

  • AWS Java SDK version used: 2.5.44
  • JDK version used: 1.8.0_192
  • Operating System and version: Amazon Linux 4.14.72-73.55.amzn2.x86_64 (from uname)
@dagnir dagnir added the feature-request A feature should be added or improved. label Jul 10, 2019
@tenjaa
Copy link

tenjaa commented Sep 1, 2020

We ran into this issue today as well.
Would you be open for a pull-request to fix this?

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants