Add download implementation for API requests #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
commented
Apr 26, 2019
| * @param <ResponseT> Pojo Response type. | ||
| * @return AsyncResponseTransformer instance. | ||
| */ | ||
| static <ResponseT> AsyncResponseTransformer<ResponseT, ResponseT> toFile(Path path, |
There was a problem hiding this comment.
note: I have another PR for this in #1222 that will be merged to master. I will update the s3-transfermanager branch once it goes through. Just didn't want it to hold this PR up.
dagnir
force-pushed
the
s3-transfermanager-download-obj
branch
2 times, most recently
from
6cc2e18 to
bd8f532
Compare
|
Should we look into doing experimental releases to Maven? |
varunnvs92
reviewed
May 1, 2019
...c/test/java/software/amazon/awssdk/core/internal/async/FileAsyncResponseTransformerTest.java
Outdated
Show resolved
Hide resolved
...ermanager/src/it/java/software/amazon/awssdk/custom/s3/transfer/DownloadIntegrationTest.java
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/custom/s3/transfer/MultipartDownloadConfiguration.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/software/amazon/awssdk/custom/s3/transfer/MultipartUploadConfiguration.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/software/amazon/awssdk/custom/s3/transfer/MultipartUploadConfiguration.java
Show resolved
Hide resolved
...ermanager/src/main/java/software/amazon/awssdk/custom/s3/transfer/TransferObjectRequest.java
Show resolved
Hide resolved
...r/src/main/java/software/amazon/awssdk/custom/s3/transfer/TransferOverrideConfiguration.java
Show resolved
Hide resolved
...c/main/java/software/amazon/awssdk/custom/s3/transfer/internal/TransferManagerUtilities.java
Show resolved
Hide resolved
...anager/src/main/java/software/amazon/awssdk/custom/s3/transfer/internal/DownloadManager.java
Show resolved
Hide resolved
...src/main/java/software/amazon/awssdk/custom/s3/transfer/internal/RequestConversionUtils.java
Show resolved
Hide resolved
varunnvs92
reviewed
May 9, 2019
| private void validateConfig() { | ||
| Validate.isPositive(multipartUploadThreshold, "multipartUploadThreshold"); | ||
| Validate.isPositive(minUploadPartSize, "minUploadPartSize"); | ||
| Validate.isTrue(minUploadPartSize <= multipartUploadThreshold, |
There was a problem hiding this comment.
why minUploadPartSize should be less than multipartUploadThreshold? It makes sense but should not be a requirement. Customer might have large objects like 1 GB and they want part size to be 50 MB or so. In that we should do 50MB parts instead of forcing them to 16MB parts.
There was a problem hiding this comment.
Makes sense. I'll change to 5MiB, since that's the absolute min set by S3.
varunnvs92
approved these changes
May 9, 2019
dagnir
force-pushed
the
s3-transfermanager-download-obj
branch
from
1b951c5 to
f94555a
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Mar 17, 2021
…30a0c1726 Pull request: release <- staging/3ae227e0-77a6-4cca-ac60-79a30a0c1726
This was referenced Mar 17, 2021
Closed
Closed
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basic implementation for
download.Motivation and Context
Testing
New unit and integration tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense