Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presign-url client support #888

Merged
merged 24 commits into from
Nov 20, 2020
Merged

Add presign-url client support #888

merged 24 commits into from
Nov 20, 2020

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Nov 11, 2020 •
edited
Loading

[x] Generates presign url clients for s3, rds and ec2 client.
[x] Modifies existing rds autofill customization and test runner.
[x] Generates presign operation functions for a handful of operations.
[x] Write test for s3 presign url operation and client.

Fixes #891

@skotambkar skotambkar mentioned this pull request Nov 11, 2020
Closed
@jasdel jasdel mentioned this pull request Nov 11, 2020
Closed
jasdel
jasdel suggested changes Nov 12, 2020
View reviewed changes
service/rds/api_op_CopyDBClusterSnapshot.go Outdated Show resolved Hide resolved
service/internal/presigned-url/middleware_test.go Outdated Show resolved Hide resolved
service/s3/internal/customizations/presigned_expires.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
service/s3/api_client.go Outdated Show resolved Hide resolved
jasdel
jasdel suggested changes Nov 16, 2020
View reviewed changes
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/customization/PresignURLAutoFill.java Outdated Show resolved Hide resolved
...en/src/main/java/software/amazon/smithy/aws/go/codegen/customization/PresignURLAutoFill.java Outdated Show resolved Hide resolved
service/internal/presigned-url/middleware.go Outdated Show resolved Hide resolved
service/internal/presigned-url/middleware.go Outdated Show resolved Hide resolved
service/rds/api_op_CopyDBClusterSnapshot.go Outdated Show resolved Hide resolved
@skotambkar skotambkar requested a review from jasdel November 17, 2020 22:30
@skotambkar skotambkar requested a review from jasdel November 18, 2020 01:07
@skotambkar skotambkar requested a review from jasdel November 19, 2020 22:25
jasdel
jasdel reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good with the exception of probably want to exclude putObject until signing issue is fixed.

@skotambkar
java codegen changes to generate presign clients for each valid servi…
9a86474 
…ce, presign operation for valid operations
@skotambkar
register runtime client plugin
d8198fa
@skotambkar
modify java codegen for existing rds autofill customization to use ne…
fdb62b4 
…w presign clients
@skotambkar
internal/presignedURL pkg changes to support new design. This is inte…
552f0c5 
…rnal package, so changes are not considered as breaking
@skotambkar
add a build middleware to handle s3 use of expires option for presign…
ab85f51 
…ed urls
@skotambkar
fix formatting
0430dfb
@skotambkar
generated s3, rds, ec2 client for verification
c7da365
@skotambkar
go mod changes for pkgs that depend on s3 and now presigned url pkgs
9817fbc
@skotambkar
feedback changes
2c1a79b
@skotambkar
generated service changes
b090abd
@skotambkar
feedback changes
ec29d82
@skotambkar
regenerated client for s3, ec2, rds
e55671e
@skotambkar
fix test
fe3e6b5
@skotambkar
fix method that disables content sha256 computation from s3 streaming…
78f6e3e 
… operation
@skotambkar
add handwritten presigning test for s3
ba5730c
@skotambkar
regenerated s3 client
0d0e272
@skotambkar skotambkar requested a review from jasdel November 20, 2020 17:22
@skotambkar skotambkar mentioned this pull request Nov 20, 2020
Closed
@skotambkar skotambkar merged commit d3b5307 into master Nov 20, 2020
@jasdel jasdel deleted the s3presign-gen branch November 25, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

@skmcgrail skmcgrail Awaiting requested review from skmcgrail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor SDK's presign URL feature
2 participants
@skotambkar @jasdel