Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/s3: Derive error code, message from HTTP status code for no body/header responses. #818

Merged
merged 10 commits into from
Oct 16, 2020
Merged

service/s3: Derive error code, message from HTTP status code for no body/header responses. #818

merged 10 commits into from
Oct 16, 2020

Conversation

skotambkar
Copy link
Contributor

  • Updates s3 xml error util to derive error code, message from HTTP status code if none is found in error response.
  • Adds customization integration for S3 HeadObject, that removes all error shapes associated with that operation.

@skotambkar skotambkar changed the title S3: Derive error code, message from HTTP status code for no body/header responses. s3: Derive error code, message from HTTP status code for no body/header responses. Oct 14, 2020
@skotambkar skotambkar requested a review from jasdel October 14, 2020 17:03
@skotambkar skotambkar requested a review from jasdel October 15, 2020 20:07
@jasdel jasdel merged commit bdabc57 into master Oct 16, 2020
@jasdel jasdel deleted the fix-unknown-error branch October 16, 2020 19:16
@jasdel jasdel changed the title s3: Derive error code, message from HTTP status code for no body/header responses. service/s3: Derive error code, message from HTTP status code for no body/header responses. Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skotambkar @jasdel