Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDK's API model sync utility to ignore models without sdkId #1459

Merged
merged 1 commit into from
Oct 18, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/repotools/cmd/syncAPIModels/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ func findSmithyModels(modelPath string) (map[string]SourceModel, error) {
name, path)
}
if shape.Traits.Service == nil {
return fmt.Errorf("smithy service doesn't have service trait %s, %s",
name, path)
// Ignore services that don't have an SDK id.
continue
}
if len(shape.Traits.Service.SDKID) == 0 {
return fmt.Errorf("smithy service doesn't have sdkId value %s, %s",
Expand Down