Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Add endpoint source property #1070

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

skotambkar
Copy link
Contributor

@skotambkar skotambkar commented Jan 22, 2021

aws/endpoints: Adds EndpointSource property to Endpoint struct. This allows customers to provide an endpoint source, which can then be used to give SDK more context on handling custom Endpoints.

@skotambkar skotambkar force-pushed the addEndpointSourceProperty branch from 8024501 to a8c40b0 Compare January 22, 2021 19:21
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs change notes.

aws/endpoints.go Outdated Show resolved Hide resolved
@skotambkar skotambkar force-pushed the addEndpointSourceProperty branch from a8c40b0 to 776fa46 Compare January 22, 2021 20:25
@skotambkar skotambkar requested a review from jasdel January 22, 2021 20:53
@skotambkar skotambkar force-pushed the addEndpointSourceProperty branch from 6bace65 to 890e07e Compare January 22, 2021 21:02
@skotambkar skotambkar merged commit 6cf9ad2 into aws:main Jan 22, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants