Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit if SDK generated presigned url should have a Content-Type header when body is nil/empty stream #923

Closed
skotambkar opened this issue Nov 20, 2020 · 2 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@skotambkar
Copy link
Contributor

We need to audit if the content-type header should be included or not for presigned requests if request body is empty.

#888 (comment)

Its debatable if the default behavior for presigned URls should be to add Content-Type header, if customer provides an empty body as input.

@skotambkar skotambkar added the feature-request A feature should be added or improved. label Nov 20, 2020
@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 20, 2020
@skotambkar
Copy link
Contributor Author

Fixed in #967

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants