Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interfaces For Testing #808

Closed
rossedman opened this issue Oct 9, 2020 · 2 comments
Closed

Interfaces For Testing #808

rossedman opened this issue Oct 9, 2020 · 2 comments
Labels
feature-request A feature should be added or improved.

Comments

@rossedman
Copy link

Is your feature request related to a problem? Please describe.
It is very hard to wrap and abstract away this SDK without interfaces. Having interfaces of any kind would help generate mocks or atleast make testing easier in an application that consumed this SDK. Right now testing is very hard with this SDK in your codebase.

Describe the solution you'd like
Interfaces for the providers of some sort that can be used when testing.

Describe alternatives you've considered
Tracking down all the methods I'm using, writing interfaces and generating mocks from those but seems like the wrong place to be.

Additional context
Add any other context or screenshots about the feature request here.
@rossedman rossedman added the feature-request A feature should be added or improved. label Oct 9, 2020
@diogomatsubara
Copy link

@rossedman See #70, I think this is a duplicate of that one.

@skmcgrail
Copy link
Member

Let's consolidate the discussion to #786 which is a duplicate issue that covers the topic of mocking client in SDK versions at or after v0.25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diogomatsubara @skmcgrail @rossedman