From 530583e1544628de18affec751f6820796eb9759 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matheus=20Guimar=C3=A3es?= <73641600+matheusorienrac@users.noreply.github.com> Date: Mon, 4 Mar 2024 16:24:02 +0000 Subject: [PATCH] fixed a typo by renaming AddAsIsPresigingMiddleware to AddAsIsPresigningMiddleware (#2486) --- .changelog/ae10fe5c667445a28a7ef7abcd638af1.json | 8 ++++++++ .changelog/c865415248e948c485e2ff07013d2236.json | 14 ++++++++++++++ .../codegen/AwsHttpPresignURLClientGenerator.java | 2 +- service/docdb/api_client.go | 2 +- service/ec2/api_client.go | 2 +- service/internal/presigned-url/context.go | 4 ++-- service/neptune/api_client.go | 2 +- service/polly/api_client.go | 2 +- service/rds/api_client.go | 2 +- service/s3/api_client.go | 2 +- service/sts/api_client.go | 2 +- 11 files changed, 32 insertions(+), 10 deletions(-) create mode 100644 .changelog/ae10fe5c667445a28a7ef7abcd638af1.json create mode 100644 .changelog/c865415248e948c485e2ff07013d2236.json diff --git a/.changelog/ae10fe5c667445a28a7ef7abcd638af1.json b/.changelog/ae10fe5c667445a28a7ef7abcd638af1.json new file mode 100644 index 00000000000..97cbcb9ff10 --- /dev/null +++ b/.changelog/ae10fe5c667445a28a7ef7abcd638af1.json @@ -0,0 +1,8 @@ +{ + "id": "ae10fe5c-6674-45a2-8a7e-f7abcd638af1", + "type": "bugfix", + "description": "Correct a typo in internal AddAsIsPresigningMiddleware API.", + "modules": [ + "service/internal/presigned-url" + ] +} \ No newline at end of file diff --git a/.changelog/c865415248e948c485e2ff07013d2236.json b/.changelog/c865415248e948c485e2ff07013d2236.json new file mode 100644 index 00000000000..33eed236137 --- /dev/null +++ b/.changelog/c865415248e948c485e2ff07013d2236.json @@ -0,0 +1,14 @@ +{ + "id": "c8654152-48e9-48c4-85e2-ff07013d2236", + "type": "bugfix", + "description": "Update internal/presigned-url dependency for corrected API name.", + "modules": [ + "service/docdb", + "service/ec2", + "service/neptune", + "service/polly", + "service/rds", + "service/s3", + "service/sts" + ] +} \ No newline at end of file diff --git a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java index 2d578673647..c608d6b37dd 100644 --- a/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java +++ b/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsHttpPresignURLClientGenerator.java @@ -484,7 +484,7 @@ private void writeConvertToPresignMiddleware( } Symbol addAsPresignMiddlewareSymbol = SymbolUtils.createValueSymbolBuilder( - "AddAsIsPresigingMiddleware", + "AddAsIsPresigningMiddleware", AwsCustomGoDependency.PRESIGNEDURL_CUSTOMIZATION).build(); writer.write("err = $T(stack)", addAsPresignMiddlewareSymbol); writer.write("if err != nil { return err }"); diff --git a/service/docdb/api_client.go b/service/docdb/api_client.go index 4295f8514b9..e265edc256a 100644 --- a/service/docdb/api_client.go +++ b/service/docdb/api_client.go @@ -643,7 +643,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/ec2/api_client.go b/service/ec2/api_client.go index d3fd49ffece..c8d167b575c 100644 --- a/service/ec2/api_client.go +++ b/service/ec2/api_client.go @@ -659,7 +659,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/internal/presigned-url/context.go b/service/internal/presigned-url/context.go index cc919701a06..b70c1e25a81 100644 --- a/service/internal/presigned-url/context.go +++ b/service/internal/presigned-url/context.go @@ -27,10 +27,10 @@ func GetIsPresigning(ctx context.Context) bool { type isPresigningKey struct{} -// AddAsIsPresigingMiddleware adds a middleware to the head of the stack that +// AddAsIsPresigningMiddleware adds a middleware to the head of the stack that // will update the stack's context to be flagged as being invoked for the // purpose of presigning. -func AddAsIsPresigingMiddleware(stack *middleware.Stack) error { +func AddAsIsPresigningMiddleware(stack *middleware.Stack) error { return stack.Initialize.Add(asIsPresigningMiddleware{}, middleware.Before) } diff --git a/service/neptune/api_client.go b/service/neptune/api_client.go index 8ac8cdf5035..c6a5cceb2c5 100644 --- a/service/neptune/api_client.go +++ b/service/neptune/api_client.go @@ -642,7 +642,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/polly/api_client.go b/service/polly/api_client.go index a3dacb3ee57..cac7587039d 100644 --- a/service/polly/api_client.go +++ b/service/polly/api_client.go @@ -647,7 +647,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/rds/api_client.go b/service/rds/api_client.go index 743a8ede6c2..3a550407da8 100644 --- a/service/rds/api_client.go +++ b/service/rds/api_client.go @@ -643,7 +643,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/s3/api_client.go b/service/s3/api_client.go index 1195e440ec6..a31c2e0acf4 100644 --- a/service/s3/api_client.go +++ b/service/s3/api_client.go @@ -852,7 +852,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err } diff --git a/service/sts/api_client.go b/service/sts/api_client.go index 8b38a505ccf..4d18dc86bd7 100644 --- a/service/sts/api_client.go +++ b/service/sts/api_client.go @@ -643,7 +643,7 @@ func (c presignConverter) convertToPresignMiddleware(stack *middleware.Stack, op if err != nil { return err } - err = presignedurlcust.AddAsIsPresigingMiddleware(stack) + err = presignedurlcust.AddAsIsPresigningMiddleware(stack) if err != nil { return err }