Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML anchor unrolling #1354

Closed
shortjared opened this issue Aug 21, 2019 · 1 comment
Closed

YAML anchor unrolling #1354

shortjared opened this issue Aug 21, 2019 · 1 comment
Labels
area/package sam package command contributors/good-first-issue Good first issue for a contributor priority/2-important

Comments

@shortjared
Copy link
Contributor

Describe your idea/feature/enhancement

This issue is to track/confirm that AWS CLI will behave the same as AWS CLI in terms of packaging resolving CloudFormation YAML anchors/aliases. aws/aws-cli#3827
@sanathkr
Copy link
Contributor

Oh thanks for the Issue. We have a copy of yamlhelper.py (surprise!) in SAM CLI that we now need to update. "sam package/deploy" commands wrap AWS CLI commands, so they should continue to work, but other parts of the CLI might not.

Would you be able to send a PR? It should just be some copy/pastas :)

@sanathkr sanathkr added area/package sam package command contributors/good-first-issue Good first issue for a contributor priority/2-important labels Aug 22, 2019
@shortjared shortjared mentioned this issue Aug 29, 2019
Merged
6 tasks
@aidansteele aidansteele mentioned this issue Dec 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/package sam package command contributors/good-first-issue Good first issue for a contributor priority/2-important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shortjared @sriram-mv @sanathkr