Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Disable Sudo] Update the Policy for DisableSudoAccessForDefaultUser #6017

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

himani2411
Copy link
Contributor

Description of changes

  • Need to Stop the Compute Fleet and Login node before we update the Sudo access for default user

Tests

  • Integ Test

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jan 16, 2024
@himani2411 himani2411 requested review from a team as code owners January 16, 2024 20:25
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63f6501) 90.21% compared to head (9b020d2) 90.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6017   +/-   ##
========================================
  Coverage    90.21%   90.21%           
========================================
  Files          180      180           
  Lines        15822    15822           
========================================
  Hits         14274    14274           
  Misses        1548     1548           
Flag Coverage Δ
unittests 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 enabled auto-merge (squash) January 16, 2024 20:55
@himani2411 himani2411 disabled auto-merge January 16, 2024 20:58
@himani2411 himani2411 enabled auto-merge (squash) January 16, 2024 21:49
@himani2411 himani2411 merged commit c98c7c6 into aws:develop Jan 16, 2024
33 checks passed
lukeseawalker pushed a commit to lukeseawalker/aws-parallelcluster that referenced this pull request Jan 17, 2024
…with COMPUTE_AND_LOGIN_NODES_STOP (aws#6017)

Co-authored-by: Himani Deshpande <[email protected]>
himani2411 added a commit to himani2411/aws-parallelcluster that referenced this pull request Feb 6, 2024
…with COMPUTE_AND_LOGIN_NODES_STOP (aws#6017)

Co-authored-by: Himani Deshpande <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants