Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid checking ScalingStrategy parameter at compile time #2489

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

NSsirena
Copy link
Contributor

@NSsirena NSsirena commented Oct 9, 2023

Description of changes

The recipe config_slurm_resume is processed also at compile time.
This causes failures since the value for the ScalingStrategy parameter is retrieved from the configuration that is available only at config time. By adding lazy we ensure that the parameter isn't checked at compile time.

  • Avoid checking ScalingStrategy parameter at compile time.

Tests

  • Manually validated by a peer launching a cluster.

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d754cf9) 76.06% compared to head (5a21ca6) 76.06%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2489   +/-   ##
========================================
  Coverage    76.06%   76.06%           
========================================
  Files           13       13           
  Lines         1876     1876           
========================================
  Hits          1427     1427           
  Misses         449      449           
Flag Coverage Δ
unittests 76.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai closed this Oct 9, 2023
@enrico-usai enrico-usai reopened this Oct 9, 2023
@NSsirena NSsirena enabled auto-merge (rebase) October 9, 2023 13:32
@NSsirena NSsirena merged commit 1fc1e2c into aws:develop Oct 9, 2023
53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants