Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed io/ioutil package as it is deprecated and used io and os package #804

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

LikithaVemulapalli
Copy link
Contributor

Issue #, if available:

Lint Eastwood checks are failing in NTH Build and Test due to the deprecated io/ioutil package used in our code.

Error: SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (staticcheck)

Description of changes:
Modified all the files that are using io/ioutil package and used io and os packages to get the same result.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LikithaVemulapalli LikithaVemulapalli marked this pull request as ready for review April 7, 2023 16:59
@LikithaVemulapalli LikithaVemulapalli requested a review from a team as a code owner April 7, 2023 16:59
Copy link
Contributor

@cjerad cjerad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@LikithaVemulapalli LikithaVemulapalli merged commit 5c44f5a into aws:main Apr 10, 2023
LikithaVemulapalli added a commit that referenced this pull request Apr 14, 2023
* eks-charts to ECR Public migration

* Removed makefile errors

* Reverted release-prep make targets

* Changes made as per PR comments

* Removed io/ioutil package as it is deprecated and used io and os package (#804)

* eks-charts to ECR Public migration

* Removed makefile errors

* Reverted release-prep make targets

* Changes made as per PR comments

* Made changes to match with script name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants