Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue-Processor should catch ASG Launch Lifecycle Hook #292

Closed
bwagner5 opened this issue Nov 17, 2020 · 0 comments
Closed

Queue-Processor should catch ASG Launch Lifecycle Hook #292

bwagner5 opened this issue Nov 17, 2020 · 0 comments
Assignees
@GavinBurris42
Labels
good first issue Good for newcomers Priority: Medium This issue will be seen by about half of users stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request

Comments

@bwagner5
Copy link
Contributor

NTH Queue-Processor should catch the ASG Launch Lifecycle Hook and complete it once the node has joined the k8s cluster successfully. Since ASG considers the instance ready when EC2 health checks pass rather than when it actually joins the k8s cluster, if ASG performs Launch-Before-Terminate, a node could be terminated before the new node is ready to go.
@bwagner5 bwagner5 added the Type: Enhancement New feature or request label Nov 17, 2020
@jillmon jillmon added good first issue Good for newcomers Priority: High This issue will be seen by most users labels Feb 11, 2021
@jillmon jillmon added the stalebot-ignore To NOT let the stalebot update or close the Issue / PR label Oct 19, 2021
@jillmon jillmon added Priority: Medium This issue will be seen by about half of users and removed Priority: High This issue will be seen by most users labels Nov 17, 2021
@GavinBurris42 GavinBurris42 mentioned this issue Aug 21, 2023
Closed
@GavinBurris42 GavinBurris42 mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GavinBurris42 GavinBurris42

Labels
good first issue Good for newcomers Priority: Medium This issue will be seen by about half of users stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bwagner5 @AustinSiu @LikithaVemulapalli @jillmon @GavinBurris42