Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube_token_ttl refreshes every 10 seconds rather than 10 minutes in 2.25.0 #353

Closed
andytson opened this issue May 22, 2022 · 7 comments
Closed

Comments

@andytson
Copy link

andytson commented May 22, 2022

Describe the question/issue

The patches introducing the kube_token_ttl fail to change the type of the configuration to FLB_CONFIG_MAP_TIME, so 10m is treated as 10 seconds.

With kube_token_ttl having type FLB_CONFIG_MAP_INT, atoi() is used to parse the default value 10m, which returns 10. Instead FLB_CONFIG_MAP_TIME should be used so 10m is parsed as 600, as per the upstream PR fluent/fluent-bit#4487

I identified the issue in the fork you use for patches https://github.com/PettitWesley/fluent-bit/pull/4/files

Configuration

default

Fluent Bit Log Output

n/a

Fluent Bit Version Info

2.25.0

Steps to reproduce issue

Deploy 2.25.0 to an EKS cluster, see the token being fetched every 10 seconds

@DrewZhang13
Copy link
Contributor

@andytson Checked upstream and there is no such issue. The issue only show in the fork: https://github.com/PettitWesley/fluent-bit/pull/4/files. May i ask why you are using that fork which is kind of personal fork? Is it possible for you to switch to official upstream?

@PettitWesley
Copy link
Contributor

@DrewZhang13 @andytson there is part of the cherry pick we added in our recent release, we released code before upstream released. However, I thought I had done the cherry pick correctly so that it defaults to 10m... this is one of our cherry picked commits: PettitWesley/fluent-bit@0527e1a

https://github.com/aws/aws-for-fluent-bit/blob/mainline/AWS_FLB_CHERRY_PICKS

@chi-bd
Copy link

chi-bd commented May 26, 2022

@PettitWesley

@andytson says "commit 8c84c5994d3ed1fa05fb3c1a60313792901a7623 is missing".
("FLB_CONFIG_MAP_INT" should be "FLB_CONFIG_MAP_TIME" for parsing string "10m")

@andytson-inviqa
Copy link

andytson-inviqa commented May 26, 2022

yes, FLB_CONFIG_MAP_TIME bit is missing, not the 10m

8cc84c5 is actually my commit in a fork I created to show the issue as a PR

@PettitWesley
Copy link
Contributor

@andytson I see. Thanks and Apologies for this. We will draft a new release today to fix it.

@PettitWesley
Copy link
Contributor

@DrewZhang13
Copy link
Contributor

DrewZhang13 commented May 26, 2022

New release is done: https://github.com/aws/aws-for-fluent-bit/releases/tag/v2.25.1
Close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants