test(test_vectors): Support reading manifests that specify a hierarchy keyring #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitvikKapila
changed the title
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
commented
Oct 2, 2024
AwsEncryptionSDK/runtimes/net/TestVectorsNative/TestVectorLib/MaterialProviderFactory.cs
Outdated
Show resolved
Hide resolved
…MaterialProviderFactory.cs
lucasmcdonald3
changed the title
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
changed the title
josecorella
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Support reading manifests that specify a hierarchy keyring.
This is a breaking-ish change.
The MPL TestVectors project is now a required dependency for the native .NET ESDK TestVector runner.
The MPL TestVectors creates a "special" local hierarchical keyring. Languages that want to test interop with other implementations of this "special" keyring must use the MPL TestVectors project.
Testing
This repo does not test any manifests that specify a hierarchical keyring. Only ESDK-Python does this right now.
ESDK-Python has a test that:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.