Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: do not add beacons when FORCE_PLAINTEXT_WRITE is used. #1232

Merged
merged 5 commits into from
Jul 29, 2024
Merged

chore: do not add beacons when FORCE_PLAINTEXT_WRITE is used. #1232

merged 5 commits into from
Jul 29, 2024

Conversation

ajewellamz
Copy link
Contributor

…h config

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ajewellamz ajewellamz requested a review from a team as a code owner July 29, 2024 18:16
lucasmcdonald3
lucasmcdonald3 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; is fix a more accurate conventional commit message than chore?

DynamoDbEncryption/dafny/DynamoDbEncryptionTransforms/test/TestFixtures.dfy
]
)
);
assume {:axiom} fresh(encryption.Modifies);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we have team standards around assume statements.
An assume in a test possibly seems OK, but could you add a comment explaining why this is needed?

Oh, I see this is common in this file. Nevermind, but I am still curious why this assume is needed

@ajewellamz ajewellamz changed the title chore: respect FORCE_PLAINTEXT_WRITE when using multitenant and searc… chore: do not add beacons when FORCE_PLAINTEXT_WRITE is used. Jul 29, 2024
seebees
seebees approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DynamoDbEncryption/dafny/DynamoDbEncryptionTransforms/src/BatchWriteItemTransform.dfy
if tableName in config.tableEncryptionConfigs {
if !IsPlainWrite(config, tableName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of name. I might have an early return instead to keep things flat, but

@ajewellamz ajewellamz merged commit 23c8a18 into main Jul 29, 2024
33 checks passed
@ajewellamz ajewellamz deleted the ajewell/multi-tenant-plain-write branch July 29, 2024 22:37
seebees pushed a commit that referenced this pull request Aug 12, 2024
@semantic-release-bot
chore(release): 3.6.1 [skip ci]
7553f9f 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
@seebees seebees mentioned this pull request Aug 12, 2024
Merged
seebees pushed a commit that referenced this pull request Aug 12, 2024
@semantic-release-bot @seebees
chore(release): 3.6.1 [skip ci]
27c6212 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees added a commit that referenced this pull request Aug 12, 2024
@seebees
chore(release): 3.6.1 [skip ci]
3509344 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees pushed a commit that referenced this pull request Aug 12, 2024
@semantic-release-bot @seebees
chore(release): 3.6.1
e051fc9 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
seebees added a commit that referenced this pull request Aug 13, 2024
@seebees @semantic-release-bot
chore(release): 3.6.1 (#1266)
64374e2 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))

---------

Co-authored-by: semantic-release-bot <[email protected]>
seebees added a commit that referenced this pull request Aug 14, 2024
@seebees
chore(release): 3.6.1 - update
890faaf 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))
* update error message ([#1270](#1270)) ([7157e4d](7157e4d))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225)
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))
@seebees seebees mentioned this pull request Aug 14, 2024
Merged
seebees added a commit that referenced this pull request Aug 14, 2024
@seebees
chore(release): 3.6.1 - update (#1271)
079c3c1 
## [3.6.1](v3.6.0...v3.6.1) (2024-08-12)

### Fixes

* allow multi-tenant queries with allow_plaintext ([#1240](#1240)) ([1487d7e](1487d7e))
* **TestVectors:** define StartUpObject in csproj ([#1231](#1231)) ([2f97bf3](2f97bf3))
* update error message ([#1270](#1270)) ([7157e4d](7157e4d))

### Maintenance

* Add examples to examine contents of query error list ([#1251](#1251)) ([b5705ee](b5705ee))
* **CI:** add smithy diff checker GHA  ([#1226](#1226)) ([86406f5](86406f5))
* **deps:** bump actions/setup-dotnet from 3 to 4 in /.github/workflows ([#1191](#1191)) ([c3b736e](c3b736e))
* **deps:** bump aws-actions/configure-aws-credentials ([#1190](#1190)) ([becbd0a](becbd0a))
* **deps:** bump com.amazonaws:aws-java-sdk-dynamodb ([#1230](#1230)) ([3aa25d0](3aa25d0))
* **deps:** bump dafny-lang/setup-dafny-action in /.github/workflows ([#1200](#1200)) ([5284f0b](5284f0b))
* **deps:** bump software.amazon.awssdk:bom ([#1227](#1227)) ([abd1727](abd1727))
* **deps:** bump software.amazon.awssdk:bom ([#1229](#1229)) ([bf3e1c3](bf3e1c3))
* **deps:** bump software.amazon.awssdk:core ([#1228](#1228)) ([9c67729](9c67729))
* do not add beacons when FORCE_PLAINTEXT_WRITE is used. ([#1232](#1232)) ([23c8a18](23c8a18))
* include bad item keys in query errors ([#1244](#1244)) ([07bba8b](07bba8b))
* **release:** 3.6.1 ([#1266](#1266)) ([64374e2](64374e2)), closes [#1240](#1240) [#1231](#1231) [#1251](#1251) [#1226](#1226) [#1191](#1191) [#1190](#1190) [#1230](#1230) [#1200](#1200) [#1227](#1227) [#1229](#1229) [#1228](#1228) [#1232](#1232) [#1244](#1244) [#1225](#1225)
* update version to snapshot ([#1225](#1225)) ([c817b5b](c817b5b))

* lint

* remove recursive reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasmcdonald3 lucasmcdonald3 lucasmcdonald3 approved these changes

@seebees seebees seebees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajewellamz @seebees @lucasmcdonald3