Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Commit current CFN state #781

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

Commit the current state of Python release CFN.

Currently, Prod release resources are commented out in AWS Console.

I also bump the default CB runner to 7.0, which has Python 3.11+.

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented Oct 1, 2024

@lucasmcdonald3 and @josecorella, I noticed you are updating the smithy model files.
Does this update need new or updated user documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@lucasmcdonald3 lucasmcdonald3 merged commit 4c84a4a into python-reviewed Oct 1, 2024
43 of 79 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the cfn-no-prod branch October 1, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants