New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KeyStoreAdmin): #631

Closed

texastony wants to merge 23 commits into seebees/add-storage-interface from tony/key-store-admin

Contributor

texastony commented Aug 23, 2024

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

seebees added 3 commits

August 13, 2024 16:45


          feat: Adding a storage option to the KeyStore

ca83676

The key store now allows for both a default DynamoDB table,
or any custom storage system.

The important aspect about the key store
is the fact that branch keys can be versioned easily,
and are cryptographically safe to use.
The actual storage medium is not important.

See: https://github.com/awslabs/aws-encryption-sdk-specification/blob/master/changes/2024-6-17_key-store-persistance/background.md#background


          Merge branch 'main' into seebees/add-storage-interface

aa96d88


          formating

4db6e2a

texastony had a problem deploying to Duvet CI

August 23, 2024 06:02

— with

GitHub Actions Failure

github-actions bot commented Aug 23, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony force-pushed the tony/key-store-admin branch from c64f574 to b139516 Compare

August 23, 2024 06:06

texastony had a problem deploying to Duvet CI

August 23, 2024 06:06

— with

GitHub Actions Failure

github-actions bot commented Aug 23, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony commented

View reviewed changes

AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/Model/KeyStoreAdmin.smithy Show resolved Hide resolved

texastony had a problem deploying to Duvet CI

August 25, 2024 20:59

— with

GitHub Actions Failure

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 22:17

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 23:00

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 23:12

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 23:32

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 23:47

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 25, 2024 23:56

— with

GitHub Actions Inactive

github-actions bot commented Aug 25, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 26, 2024 00:52

— with

GitHub Actions Inactive

github-actions bot commented Aug 26, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 26, 2024 01:09

— with

GitHub Actions Inactive

github-actions bot commented Aug 26, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 26, 2024 01:11

— with

GitHub Actions Inactive

github-actions bot commented Aug 26, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 26, 2024 01:17

— with

GitHub Actions Inactive

github-actions bot commented Aug 26, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony temporarily deployed to Duvet CI

August 26, 2024 03:07

— with

GitHub Actions Inactive

github-actions bot commented Aug 26, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony added 20 commits

August 27, 2024 12:05


          Merge branch 'main' into seebees/add-storage-interface

2e8267f


          feat(KeyStoreAdmin):

354bdf8


          First cut of CreateKey defer to existing code

92bdcf6

Result of:
`git cherry-pick 5195f61dcdfbe1deef94d98733c50330b57c36cf --no-commit`
followed by manual resolution.


          feat(KeyStoreAdmin): Stubbed Index.dfy

35d5f9e


          feat(KeyStoreAdmin): Maybe working Index & CreateKey?

7f74ecb


          Now with fixed smithy-dafny

be4e6bf

Authored by @seebees


          feat(KeyStoreAdmin): try getting rid of Union for client

b46feba


          feat(KeyStoreAdmin): try getting rid of Union for client

2fafeb8


          feat(KeyStoreAdmin): Polymorph Java

03e4758


          feat(KeyStoreAdmin): Polymorph Net

cdb5c3a


          feat(KeyStoreAdmin): fix Create Key for no union

55be861


          feat(KeyStoreAdmin): Java Default & TestVector Makefile

bd43572


          feat(KeyStoreAdmin): Benerate KMS -> Kms

46cffd2


          feat(KeyStoreAdmin): formatting

b9fbf9a


          feat(KeyStoreAdmin): formatting

8eda3cc


          feat(KeyStoreAdmin): Polymorph Patches

ef42c48


          test(KeyStoreAdmin): a real test

0ea0fd7


          test(KeyStoreAdmin): a real test that does not conflict?

add23ca


          test(KeyStoreAdmin): a real test that does not conflict?

0c42957


          test(KeyStoreAdmin): a real test that does not conflict?

texastony force-pushed the tony/key-store-admin branch from 661072e to 3801746 Compare

August 27, 2024 20:53

texastony temporarily deployed to Duvet CI

August 27, 2024 20:53

— with

GitHub Actions Inactive

github-actions bot commented Aug 27, 2024

@texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

seebees force-pushed the seebees/add-storage-interface branch 2 times, most recently from 56e5262 to 53c9c25 Compare

September 17, 2024 19:29

texastony closed this

texastony deleted the tony/key-store-admin branch

September 28, 2024 21:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet