Mutations/tony/decrypt encrypt strat #1043
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected changes to the release files or to the check-files action |
|
Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS |
texastony
commented
Nov 22, 2024
| @@ -291,6 +291,111 @@ module {:options "/functionSyntax:4" } KMSKeystoreOperations { | |||
| return Success(reEncryptResponse); | |||
| } | |||
|
|
|||
| method VerifyViaDecryptEncryptKey( | |||
There was a problem hiding this comment.
Praise: this is great.
Having a KMS Configuration means we can use it for VersionKey in the future.
You have raised the bar.
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStore/test/Fixtures.dfy
Show resolved
Hide resolved
Comment on lines
+163
to
+171
| "Key Store Items are authenticated and re-wrapped via a Decrypt and then Encrypt request. | ||
| This is two separate requests to Key Management, as compared to one. | ||
| But the Decrypt requests will use the Decrypt KMS Client (and Grant Tokens), | ||
| while the Encrypt requests will use the Encrypt KMS Client (and Grant Tokens). | ||
| This option affords for different credentials to be utilized, | ||
| based on the operation. | ||
| When Generating new material, | ||
| KMS GenerateDataKeyWithoutPlaintext will be executed against | ||
| the Encrypt option.") |
There was a problem hiding this comment.
We need to revise this documentation to detail how Verify works.
|
@texastony and @texastony, I noticed you are updating the smithy model files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.