Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Python): CMCs release lock for unhandled runtime exceptions #979

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
We may want tell Dafny about this,
so they push this fix into their standard libraries Concurrent caches.

@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review November 12, 2024 19:36
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner November 12, 2024 19:36
@lucasmcdonald3
Copy link
Contributor Author

Nice catch. We may want tell Dafny about this, so they push this fix into their standard libraries Concurrent caches.

dafny-lang/dafny#5913

@lucasmcdonald3 lucasmcdonald3 merged commit 1510b77 into main Nov 12, 2024
108 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the python-cmc-exceptions branch November 12, 2024 20:11
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Nov 15, 2024
## [1.7.5](v1.7.4...v1.7.5) (2024-11-15)

### Bug Fixes

* **Python-Release:** Run validate tests from release commit ([41c0c94](41c0c94))
* **Python:** CMCs release lock for unhandled runtime exceptions ([aws#979](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/979)) ([1510b77](1510b77))
* return error on interrupted sleep ([aws#993](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/993)) ([f49460a](f49460a))
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Nov 15, 2024
## [1.7.5](v1.7.4...v1.7.5) (2024-11-15)

### Bug Fixes

* **Python-Release:** Run validate tests from release commit ([41c0c94](41c0c94))
* **Python:** CMCs release lock for unhandled runtime exceptions ([aws#979](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/979)) ([1510b77](1510b77))
* return error on interrupted sleep ([aws#993](https://github.com/lucasmcdonald3/aws-cryptographic-material-providers-library/issues/993)) ([f49460a](f49460a))
seebees pushed a commit that referenced this pull request Nov 19, 2024
# [1.8.0](v1.7.4...v1.8.0) (2024-11-19)

### Bug Fixes

* Drop SelectOpt from MutableMap ([bdb6509](bdb6509))
* Externs ([0bc1f96](0bc1f96))
* formatting ([b608ab8](b608ab8))
* **Python-Release:** Run validate tests from release commit ([41c0c94](41c0c94))
* **Python:** CMCs release lock for unhandled runtime exceptions ([#979](#979)) ([1510b77](1510b77))
* **Python:** return error on interrupted sleep ([#1003](#1003)) ([405cf37](405cf37))
* remove input and output traits on DynamoDB operations ([#1012](#1012)) ([8377acf](8377acf))
* return error on interrupted sleep ([#993](#993)) ([f49460a](f49460a))
* rust CI ([42e39cc](42e39cc))

### Features

* **Rust:** Interop test vectors; bump Dafny to 4.9.0 ([#1004](#1004)) ([a505a30](a505a30))
* Storm cache supports millisecond resolution ([#1011](#1011)) ([6f09d5d](6f09d5d))
seebees added a commit that referenced this pull request Nov 19, 2024
* chore(release): 1.8.0 [skip ci]

# [1.8.0](v1.7.4...v1.8.0) (2024-11-19)

### Bug Fixes

* Drop SelectOpt from MutableMap ([bdb6509](bdb6509))
* Externs ([0bc1f96](0bc1f96))
* formatting ([b608ab8](b608ab8))
* **Python-Release:** Run validate tests from release commit ([41c0c94](41c0c94))
* **Python:** CMCs release lock for unhandled runtime exceptions ([#979](#979)) ([1510b77](1510b77))
* **Python:** return error on interrupted sleep ([#1003](#1003)) ([405cf37](405cf37))
* remove input and output traits on DynamoDB operations ([#1012](#1012)) ([8377acf](8377acf))
* return error on interrupted sleep ([#993](#993)) ([f49460a](f49460a))
* rust CI ([42e39cc](42e39cc))

### Features

* **Rust:** Interop test vectors; bump Dafny to 4.9.0 ([#1004](#1004)) ([a505a30](a505a30))
* Storm cache supports millisecond resolution ([#1011](#1011)) ([6f09d5d](6f09d5d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants