fix: add ECDH error message for Rust #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
previously approved these changes
Aug 6, 2024
| @@ -124,6 +124,9 @@ module TestECDH { | |||
| const OUT_OF_BOUNDS_ERR_MSG_NET6 := "value invalid for Fp field element (Parameter 'x')" | |||
| const OUT_OF_BOUNDS_ERR_MSG_NE48 := "value invalid for Fp field element\r\nParameter name: x" | |||
|
|
|||
| // Rust does not provide a separate error message for infinity or out of bounds | |||
| const BAD_X509_KEY_RUST := "Invalid X509 Public Key." | |||
There was a problem hiding this comment.
nit:
Suggested change
| const BAD_X509_KEY_RUST := "Invalid X509 Public Key." | |
| const BAD_X509_KEY_RUST_ERR_MSG := "Invalid X509 Public Key." |
| @@ -285,6 +288,7 @@ module TestECDH { | |||
| var errMsg := validPublicKey.error.message; | |||
|
|
|||
| expect ( | |||
| errMsg == BAD_X509_KEY_RUST || | |||
There was a problem hiding this comment.
Suggested change
| errMsg == BAD_X509_KEY_RUST || | |
| errMsg == BAD_X509_KEY_RUST_ERR_MSG || |
| @@ -334,6 +338,7 @@ module TestECDH { | |||
| var errMsg := validPublicKey.error.message; | |||
| expect ( | |||
| seq_contains(errMsg, OUT_OF_BOUNDS_ERR_MSG_JAVA) || | |||
| errMsg == BAD_X509_KEY_RUST || | |||
There was a problem hiding this comment.
Suggested change
| errMsg == BAD_X509_KEY_RUST || | |
| errMsg == BAD_X509_KEY_RUST_ERR_MSG || |
texastony
pushed a commit
that referenced
this pull request
Aug 23, 2024
* fix: add ECDH error message for Rust
lucasmcdonald3
pushed a commit
that referenced
this pull request
Aug 29, 2024
* fix: add ECDH error message for Rust
josecorella
pushed a commit
that referenced
this pull request
Sep 10, 2024
* add ECDH error message for Rust ([#574](#574)) ([473a34a](473a34a)) * **DDB-Model:** DDB Supports 100 actions per Transaction ([#692](#692)) ([8a67843](8a67843)) * GetCurrentTimeStamp returns ISO8601 format ([#575](#575)) ([c07a51f](c07a51f)) * maintain order in test vectors for languages with parallel tests ([#641](#641)) ([8c8a38f](8c8a38f)) * Remove 4.4 DDB and KMS patches, abstract test to work on later Dafny versions ([#611](#611)) ([d51d648](d51d648)) * Remove uses of `:|` ([#618](#618)) ([f12fe5b](f12fe5b)) * test vector help text ([#657](#657)) ([0fedaf1](0fedaf1)) * bump dafny verification and code gen to dafny 4.8.0 ([#520](#520)) ([e16539e](e16539e)) * **post-release:** Change back to 1.5.1-SNAPSHOT ([09cd9a4](09cd9a4))
Merged
lucasmcdonald3
pushed a commit
that referenced
this pull request
Sep 24, 2024
* fix: add ECDH error message for Rust
lucasmcdonald3
pushed a commit
to lucasmcdonald3/aws-cryptographic-material-providers-library
that referenced
this pull request
Sep 26, 2024
* fix: add ECDH error message for Rust
lucasmcdonald3
pushed a commit
to lucasmcdonald3/aws-cryptographic-material-providers-library
that referenced
this pull request
Oct 1, 2024
* fix: add ECDH error message for Rust
ajewellamz
added a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.